Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds page change event #189

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Adds page change event #189

merged 1 commit into from
Sep 15, 2023

Conversation

gassio
Copy link
Contributor

@gassio gassio commented Sep 7, 2023 •
edited
Loading

  • Adds page change event
  • Adds first and last pagination items

Adds page change event
52f3c97 
Adds first and last pagination items
@cogor cogor added 🔧 enhancement New feature or request ✨ good first issue Good for newcomers labels Sep 8, 2023
@cogor
Copy link
Collaborator

cogor commented Sep 8, 2023

First and last buttons visibility should be optional, add a prop to show first and last buttons
I think console.log in example may need to replace with alert with text "first|last button clicked"

@cogor cogor linked an issue Sep 8, 2023 that may be closed by this pull request
Pagination functionality for Vue.js #186
Closed
@cogor cogor changed the base branch from main to wip_pagination_event September 15, 2023 13:30
@cogor cogor merged commit 96b735b into themesberg:wip_pagination_event Sep 15, 2023
7 checks passed
cogor added a commit that referenced this pull request Sep 21, 2023
@cogor @gassio
Pagination component improvements (#198)
1370f1c 
* Adds page change event (#189)

Adds first and last pagination items

Co-authored-by: gassio <[email protected]>

* feat: Pagination component refactoring

---------

Co-authored-by: gassio <[email protected]>
Co-authored-by: gassio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔧 enhancement New feature or request ✨ good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination functionality for Vue.js
2 participants
@gassio @cogor